Re: [PATCH v11 5/9] KVM: X86: Refresh CPUID once guest XSS MSR changes

From: Paolo Bonzini
Date: Sat Apr 25 2020 - 09:19:34 EST


On 23/04/20 19:34, Sean Christopherson wrote:
>> if (!kvm_cpu_cap_has(X86_FEATURE_XSAVES))
>> supported_xss = 0;
>> + else
>> + supported_xss = host_xss & KVM_SUPPORTED_XSS;
> Silly nit: I'd prefer to invert the check, e.g.
>
> if (kvm_cpu_cap_has(X86_FEATURE_XSAVES))
> supported_xss = host_xss & KVM_SUPPORTED_XSS;
> else
> supported_xss = 0;
>

Also a nit: Linux coding style should be

supported_xss = 0;
if (kvm_cpu_cap_has(X86_FEATURE_XSAVES))
supported_xss = host_xss & KVM_SUPPORTED_XSS;

Paolo