Re: [PATCH] objtool: orc_gen: Fix memory leak in create_orc_entry

From: Gustavo A. R. Silva
Date: Mon Apr 27 2020 - 13:24:44 EST


Hi Josh,

On 4/27/20 09:44, Josh Poimboeuf wrote:
> On Mon, Apr 27, 2020 at 08:35:33AM -0500, Gustavo A. R. Silva wrote:
>> In case memory resources for rela were allocated, release them before
>> return.
>>
>> Addresses-Coverity-ID: 1462331 ("Resource leak")
>> Fixes: e81e07244325 ("objtool: Support Clang non-section symbols in ORC generation")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>
> Hi Gustavo,
>
> For performance reasons, our policy is to allow memory leaks in error
> and exit paths. So you may want to turn off Coverity resource leak
> checking for objtool.
>

Got it. That's good to know.

Thank you.
--
Gustavo