Re: [PATCH v2] scripts: scripts/tags.sh

From: Greg KH
Date: Tue Apr 28 2020 - 03:06:25 EST


On Tue, Apr 28, 2020 at 01:35:09PM +0800, xujialu wrote:
> Update function all_compiled_sources for only compiled source files.

Your subject line needs a lot of work. Please read the section entitled
"The canonical patch format" in the kernel file,
Documentation/SubmittingPatches for what is needed in order to properly
describe the change.

>
> Usage:
> 1) COMPILED_SOURCE=1 make {cscope,gtags}
> 2) COMPILED_SOURCE=1 KBUILD_ABS_SRCTREE=1 make {cscope,gtags}
> 3) COMPILED_SOURCE=1 ./scripts/tags.sh {cscope,gtags}
> 4) COMPILED_SOURCE=1 ABSPWD=$PWD/ ./scripts/tags.sh {cscope,gtags}

And you did not document this somewhere for people to be able to find
out? Also not good :(

greg k-h