Re: [PATCH] pinctrl: nomadik: db8500: remove some unused symbols

From: Linus Walleij
Date: Tue Apr 28 2020 - 05:56:41 EST


On Fri, Apr 17, 2020 at 9:08 AM Jason Yan <yanaijie@xxxxxxxxxx> wrote:

> Fix the following gcc warning:
>
> drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c:899:20: warning:
> âsbag_groupsâ defined but not used [-Wunused-const-variable=]
> DB8500_FUNC_GROUPS(sbag, "sbag_oc2_1", "sbag_oc4_1");
> ^
> drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c:570:23: warning:
> âipgpio6_c_2_pinsâ defined but not used [-Wunused-const-variable=]
> static const unsigned ipgpio6_c_2_pins[] = { DB8500_PIN_G3 };
> ^~~~~~~~~~~~~~~~
> drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c:472:23: warning:
> âmc1dir_a_1_pinsâ defined but not used [-Wunused-const-variable=]
> static const unsigned mc1dir_a_1_pins[] = { DB8500_PIN_AH13,
> DB8500_PIN_AG12,
> ^~~~~~~~~~~~~~~
> drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c:453:23: warning:
> âmodem_a_1_pinsâ defined but not used [-Wunused-const-variable=]
> static const unsigned modem_a_1_pins[] = { DB8500_PIN_D22,
> DB8500_PIN_C23,
> ^~~~~~~~~~~~~~
> drivers/pinctrl/nomadik/pinctrl-nomadik-db8500.c:430:23: warning:
> âkpskaskb_a_1_pinsâ defined but not used [-Wunused-const-variable=]
> static const unsigned kpskaskb_a_1_pins[] = { DB8500_PIN_D17,
> DB8500_PIN_D16 };
> ^~~~~~~~~~~~~~~~~
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>

These should not be deleted but used properly. I've sent another
patch fixing the problem and adding you as Reported-by.

Yours,
Linus Walleij