Re: [PATCH v2] drm/mcde: dsi: Fix return value check in mcde_dsi_bind()

From: Markus Elfring
Date: Thu Apr 30 2020 - 07:56:41 EST


> The of_drm_find_bridge() function returns NULL on error, it doesn't return
> error pointers so this check doesn't work.

How do you think about a wording variant like the following?

Change description:
An error pointer check was performed after a call of the
function âof_drm_find_bridgeâ despite of the detail
that failures are indicated for the bridge search
by null pointers instead.
Thus adjust a check for the failure predicate
and the corresponding exception handling.


Regards,
Markus