Re: [PATCH 4/6] dt-bindings: gnss: Add binding for Motorola Mapphone MDM6600 GNSS

From: Tony Lindgren
Date: Fri May 01 2020 - 17:25:10 EST


* Rob Herring <robh@xxxxxxxxxx> [200501 21:20]:
> On Thu, Apr 30, 2020 at 10:46:13AM -0700, Tony Lindgren wrote:
> > Add a binding document for Motorola Mapphone MDM6600 GNSS driver that
> > can be used with phones such as droid4.
> >
> > Signed-off-by: Tony Lindgren <tony@xxxxxxxxxxx>
> > ---
> > .../devicetree/bindings/gnss/motmdm.yaml | 29 +++++++++++++++++++
> > 1 file changed, 29 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/gnss/motmdm.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/gnss/motmdm.yaml b/Documentation/devicetree/bindings/gnss/motmdm.yaml
> > new file mode 100644
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/gnss/motmdm.yaml
> > @@ -0,0 +1,29 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/gnss/motmdm.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Motorola Mapphone MDM6600 GNSS binding
> > +
> > +maintainers:
> > + - Tony Lindgren <tony@xxxxxxxxxxx>
> > +
> > +properties:
> > + compatible:
> > + const: motorola,mapphone-mdm6600-gnss
> > +
> > + reg:
> > + items:
> > + description: TS 27.010 channel the GNSS device is using
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +examples:
> > + - |
> > + gnss@4 {
>
> This is a child of what's in patch 2? I think I'd just combine this
> schema into it.

Yes it's a child node for patch 2 in this series. I'll combine them
into a single binding.

> Or you can leave it, but better to have complete examples (which will
> help fix what my bot reports). Examples have a default
> #address/size-cells of 1.

OK. In this case we have just #size-cells = <0>.

Regards,

Tony