Re: [PATCH v7 3/3] phy: intel: Add driver support for ComboPhy

[Dilip Kota]

On 5/4/2020 5:20 PM, Vinod Koul wrote:
> On 04-05-20, 16:26, Dilip Kota wrote:
> > On 5/4/2020 3:29 PM, Vinod Koul wrote:
> > > On 30-04-20, 15:15, Dilip Kota wrote:
> > >
> > > > +					  u32 mask, u32 val)
> > > > +{
> > > > +	u32 reg_val;
> > > > +
> > > > +	reg_val = readl(base + reg);
> > > > +	reg_val &= ~mask;
> > > > +	reg_val |= FIELD_PREP(mask, val);
> > > > +	writel(reg_val, base + reg);
> > > bypassing regmap here... why?
> > It is not regmap address, one of the below two addresses are passed to this
> > function.
> okay, perhaps add a comment somewhere that regmap is not used for this
> base?
I dont see a need of adding a comment, describing don't do regmap here.
> > struct intel_combo_phy {
> > ...
> >  ÂÂÂÂÂÂÂ void __iomemÂÂÂÂÂÂÂÂÂÂÂ *app_base;
> >  ÂÂÂÂÂÂÂ void __iomemÂÂÂÂÂÂÂÂÂÂÂ *cr_base;
> > ...
> > }
>
> > > > +static int intel_cbphy_calibrate(struct phy *phy)
> > > > +{
> > > > +	struct intel_cbphy_iphy *iphy = phy_get_drvdata(phy);
> > > > +	struct intel_combo_phy *cbphy = iphy->parent;
> > > > +	void __iomem *cr_base = cbphy->cr_base;
> > > > +	int val, ret, id;
> > > > +
> > > > +	if (cbphy->phy_mode != PHY_XPCS_MODE)
> > > > +		return 0;
> > > > +
> > > > +	id = PHY_ID(iphy);
> > > > +
> > > > +	/* trigger auto RX adaptation */
> > > > +	combo_phy_w32_off_mask(cr_base, CR_ADDR(PCS_XF_ATE_OVRD_IN_2, id),
> > > > +			       ADAPT_REQ_MSK, 3);
> > > > +	/* Wait RX adaptation to finish */
> > > > +	ret = readl_poll_timeout(cr_base + CR_ADDR(PCS_XF_RX_ADAPT_ACK, id),
> > > > +				 val, val & RX_ADAPT_ACK_BIT, 10, 5000);
> > > > +	if (ret)
> > > > +		dev_err(cbphy->dev, "RX Adaptation failed!\n");
> > > you want to continue her and not return error?
> > Next step is stopping the Adaptation, it should be done in both error and
> > success case.
> Again documenting this helps, pls add some comments on this behaviour
Comments are already in place, mentioning Start and Stop of Rx 
Adaptation. And Stop is being is done as Start is triggered, so not 
needed to mention error and success.

Regards,
Dilip
>