Re: [PATCH] net: enetc: fix an issue about leak system resources

From: Markus Elfring
Date: Mon May 04 2020 - 10:12:31 EST


> the related system resources were not released when enetc_hw_alloc()
> return error in the enetc_pci_mdio_probe(), add iounmap() for error
> handling label "err_hw_alloc" to fix it.

How do you think about a wording variant like the following?

Subject:
[PATCH v2] net: enetc: Complete exception handling in enetc_pci_mdio_probe()

Change description:
A call of the function âenetc_hw_allocâ can fail here.
The corresponding system resources were not released then.
Thus move a call of the function âiounmapâ behind
the label âerr_hw_allocâ.


Would you like to reduce the labels for this function implementation instead?

Regards,
Markus