Re: [PATCH v5] MIPS: Truncate link address into 32bit for 32bit kernel

[Thomas Bogendoerfer]

On Tue, May 05, 2020 at 12:09:46AM +0800, Jiaxun Yang wrote:
> 
> ä 2020å5æ4æ GMT+08:00 äå11:46:13, Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx> åå:
> >On Fri, Apr 24, 2020 at 01:22:30PM +0100, Maciej W. Rozycki wrote:
> >> On Thu, 23 Apr 2020, Jiaxun Yang wrote:
> >> 
> >> > > Alternatively, have you made any attempt to verify if actually replacing 
> >> > >the setting for VMLINUX_LOAD_ADDRESS would be safe?  Glancing over its use 
> >> > >there do not appear to be many places.
> >> > 
> >> > Limited experiments showed it should be fine...
> >> > 
> >> > But MIPS kernel has some design I'm not really familiar with like SYM32 for
> >> > 64-bit kernel and special address space design for Trap-and-emul KVM.
> >> 
> >>  This only affects CONFIG_32BIT kernels, so SYM32 does not apply; I can't 
> >> comment on KVM.  There's still that bunch of:
> >> 
> >> $(shell expr $(...) \< 0xffffffff80000000)
> >> 
> >> constructs I mentioned before, so let's leave your change as it stands at 
> >> this time.  Please do rename the variable as I suggested though, I hope 
> >> that's not a big deal.
> >
> >Jiaxun, are you going to send an update with this change ?
> 
> Sorry my mail server missed Maciej's reply.
> 
> Should I send another version or you just fix it at apply time?

please send a new version, thank you.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]