Re: [PATCH v4 2/7] KVM: arm64: clean up redundant 'kvm_run' parameters

From: Marc Zyngier
Date: Tue May 05 2020 - 04:40:04 EST


Hi Tianjia,

On 2020-04-27 05:35, Tianjia Zhang wrote:
In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu'
structure. For historical reasons, many kvm-related function parameters
retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This
patch does a unified cleanup of these remaining redundant parameters.

Signed-off-by: Tianjia Zhang <tianjia.zhang@xxxxxxxxxxxxxxxxx>

On the face of it, this looks OK, but I haven't tried to run the
resulting kernel. I'm not opposed to taking this patch *if* there
is an agreement across architectures to take the series (I value
consistency over the janitorial exercise).

Another thing is that this is going to conflict with the set of
patches that move the KVM/arm code back where it belongs (arch/arm64/kvm),
so I'd probably cherry-pick that one directly.

Thanks,

M.


--
Jazz is not dead. It just smells funny...