Re: [PATCH] sysctl: fix unused function warning

From: Song Liu
Date: Tue May 05 2020 - 14:25:21 EST




> On May 5, 2020, at 7:07 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote:
>
> The newly added bpf_stats_handler function has the wrong #ifdef
> check around it, leading to an unused-function warning when
> CONFIG_SYSCTL is disabled:
>
> kernel/sysctl.c:205:12: error: unused function 'bpf_stats_handler' [-Werror,-Wunused-function]
> static int bpf_stats_handler(struct ctl_table *table, int write,
>
> Fix the check to match the reference.
>
> Fixes: d46edd671a14 ("bpf: Sharing bpf runtime stats with BPF_ENABLE_STATS")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Acked-by: Song Liu <songliubraving@xxxxxx>

Thanks for the fix!