Re: Re: [PATCH net v2 0/2] Revert the 'socket_alloc' life cycle change

From: SeongJae Park
Date: Wed May 06 2020 - 02:25:02 EST


On Tue, 05 May 2020 12:00:49 -0700 (PDT) David Miller <davem@xxxxxxxxxxxxx> wrote:

> From: David Miller <davem@xxxxxxxxxxxxx>
> Date: Tue, 05 May 2020 11:48:25 -0700 (PDT)
>
> > Series applied and queued up for -stable, thanks.
>
> Nevermind, this doesn't even compile.
>
> net/smc/af_smc.c: In function âsmc_switch_to_fallbackâ:
> net/smc/af_smc.c:473:19: error: âsmc->clcsock->wqâ is a pointer; did you mean to use â->â?
> 473 | smc->clcsock->wq.fasync_list =
> | ^
> | ->
> net/smc/af_smc.c:474:25: error: âsmc->sk.sk_socket->wqâ is a pointer; did you mean to use â->â?
> 474 | smc->sk.sk_socket->wq.fasync_list;
> | ^
> | ->
>
> So I had to revert these changes.
>
> When you make a change of this magnitude and scope you must do an
> allmodconfig build.

Definitely my fault. I will fix this in next spin.


Thanks,
SeongJae Park

>
> Thank you.