Re: [PATCH] [net-next, v2] dsa: sja1105: dynamically allocate stats structure

From: David Miller
Date: Wed May 06 2020 - 20:47:59 EST


From: Arnd Bergmann <arnd@xxxxxxxx>
Date: Tue, 5 May 2020 17:38:19 +0200

> The addition of sja1105_port_status_ether structure into the
> statistics causes the frame size to go over the warning limit:
>
> drivers/net/dsa/sja1105/sja1105_ethtool.c:421:6: error: stack frame size of 1104 bytes in function 'sja1105_get_ethtool_stats' [-Werror,-Wframe-larger-than=]
>
> Use dynamic allocation to avoid this.
>
> Fixes: 336aa67bd027 ("net: dsa: sja1105: show more ethtool statistics counters for P/Q/R/S")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> v2: remove extra ';'
> remove bogus include/linux/warnings.h change

Applied, thanks Arnd.