Re: [PATCH v3 3/6] pstore/ram: Refactor DT size parsing

From: Pavel Tatashin
Date: Thu May 07 2020 - 08:58:32 EST


On Wed, May 6, 2020 at 5:15 PM Kees Cook <keescook@xxxxxxxxxxxx> wrote:
>
> Refactor device tree size parsing routines to be able to pass a non-zero
> default value for providing a configurable default for the coming
> "max_reason" field.
>
> Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>

ramoops_parse_dt_size
parse_size

Are used to parse flags, and max-reason properties, so the "size" in
their names become outdated. How about:
ramoops_parse_dt_prop
parse_prop

Otherwise it looks good.

Thank you,
Pasha