Re: [PATCH -next] mmc: sdhci-pci-gli: Make sdhci_pci_gli_resume static

From: Ulf Hansson
Date: Thu May 07 2020 - 09:16:45 EST


On Thu, 7 May 2020 at 14:14, Samuel Zou <zou_wei@xxxxxxxxxx> wrote:
>
> Fix the following sparse warning:
>
> drivers/mmc/host/sdhci-pci-gli.c:343:5: warning:
> symbol 'sdhci_pci_gli_resume' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Samuel Zou <zou_wei@xxxxxxxxxx>

This actually fixes a commit that I on my fixes branch, which is also
targeted for stable.

Therefore, I decided to squash this into the offending commit and
adding your sob tag, with a note about what you fixed.

Kind regards
Uffe

> ---
> drivers/mmc/host/sdhci-pci-gli.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> index bdb6336..fd76aa6 100644
> --- a/drivers/mmc/host/sdhci-pci-gli.c
> +++ b/drivers/mmc/host/sdhci-pci-gli.c
> @@ -340,7 +340,7 @@ static u32 sdhci_gl9750_readl(struct sdhci_host *host, int reg)
> }
>
> #ifdef CONFIG_PM_SLEEP
> -int sdhci_pci_gli_resume(struct sdhci_pci_chip *chip)
> +static int sdhci_pci_gli_resume(struct sdhci_pci_chip *chip)
> {
> struct sdhci_pci_slot *slot = chip->slots[0];
>
> --
> 2.6.2
>