Re: [PATCH -next] ipack: tpci200: fix error return code in tpci200_register()

From: Samuel Iglesias Gonsálvez
Date: Thu May 07 2020 - 10:59:14 EST


Hello Wei,

Thanks for the patch!

Patch is,

Acked-by: Samuel Iglesias Gonsalvez <siglesias@xxxxxxxxxx>

Greg, Would you mind picking this patch series through your char-misc
tree?

Thanks!

Sam

On Thu, 2020-05-07 at 09:42 +0000, Wei Yongjun wrote:
> Fix to return negative error code -ENOMEM from the ioremap() error
> handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 43986798fd50 ("ipack: add error handling for ioremap_nocache")
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> ---
> drivers/ipack/carriers/tpci200.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ipack/carriers/tpci200.c
> b/drivers/ipack/carriers/tpci200.c
> index 8a9c169..b5eec18 100644
> --- a/drivers/ipack/carriers/tpci200.c
> +++ b/drivers/ipack/carriers/tpci200.c
> @@ -309,6 +309,7 @@ static int tpci200_register(struct tpci200_board
> *tpci200)
> "(bn 0x%X, sn 0x%X) failed to map driver user
> space!",
> tpci200->info->pdev->bus->number,
> tpci200->info->pdev->devfn);
> + res = -ENOMEM;
> goto out_release_mem8_space;
> }
>
>
>
>

Attachment: signature.asc
Description: This is a digitally signed message part