Re: [PATCH v4 14/18] static_call: Add static_cond_call()

From: Peter Zijlstra
Date: Fri May 08 2020 - 12:17:36 EST


On Fri, May 08, 2020 at 10:47:04AM -0500, Josh Poimboeuf wrote:

> And if you're calling it
>
> DEFINE_STATIC_CALL_NULL
>
> then it seems like
>
> ARCH_DEFINE_STATIC_CALL_NULL
>
> would be the logical name rather than RETTRAMP?

But that looses the TRAMP, and ARCH_DEFINE_STATIC_CALL_NULL_TRAMP so
damn long, then again, it's only 2 chars more than what I have now,
sure, lets do it.

> Still not crazy about static_cond_call(), though I think at least
> changing it to static_call_cond() would be better for namespacing
> reasons.

Done.