Re: [PATCH] mm, compaction: Indicate when compaction is manually triggered by sysctl

From: Guilherme Piccoli
Date: Fri May 08 2020 - 15:02:30 EST


On Fri, May 8, 2020 at 3:31 PM David Rientjes <rientjes@xxxxxxxxxx> wrote:
> It doesn't make sense because it's only being done here for the entire
> system, there are also per-node sysfs triggers so you could do something
> like iterate over the nodemask of all nodes with memory and trigger
> compaction manually and then nothing is emitted to the kernel log.
>
> There is new statsfs support that Red Hat is proposing that can be used
> for things like this. It currently only supports KVM statistics but
> adding MM statistics is something that would be a natural extension and
> avoids polluting both the kernel log and /proc/vmstat.

Thanks for the review. Is this what you're talking about [0] ? Very interesting!

Also, I agree about the per-node compaction, it's a good point. But at
the same time, having the information on the number of manual
compaction triggered is interesting, at least for some users. What if
we add that as a per-node stat in zoneinfo?

Cheers,

Guilherme


[0] lore.kernel.org/kvm/20200427141816.16703-1-eesposit@xxxxxxxxxx