Re: [PATCH v7 4/5] usb: ehci: Add new EHCI driver for Broadcom STB SoC's

From: Alan Cooper
Date: Fri May 08 2020 - 16:32:54 EST


On Fri, May 8, 2020 at 2:46 PM Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, 7 May 2020, Al Cooper wrote:
>
> > Add a new EHCI driver for Broadcom STB SoC's. A new EHCI driver
> > was created instead of adding support to the existing ehci platform
> > driver because of the code required to workaround bugs in the EHCI
> > controller. The primary workround is for a bug where the Core
> > violates the SOF interval between the first two SOFs transmitted after
> > resume. This only happens if the resume occurs near the end of a
> > microframe. The fix is to intercept the echi-hcd request to complete
> > RESUME and align it to the start of the next microframe.
> >
> > Signed-off-by: Al Cooper <alcooperx@xxxxxxxxx>
> > Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
>
> Adding a new EHCI platform-specific driver is okay with me. However,
> this patch does not include most of the changes you discussed with
> Greg. I assume you will submit a revised version with those changes in
> place; when you do I will Ack it.
>
> Alan Stern
>

I mistakenly sent a partially fixed version instead of the version
with all the fixes (git stashed). I'm sending v8 will all the fixes.

Thanks



Thanks
Al