Re: [PATCH] iio: sca3000: Remove an erroneous get_device() call in sca3000_read_data()

From: Jonathan Cameron
Date: Sun May 10 2020 - 05:56:08 EST


On Wed, 6 May 2020 17:30:06 +0200
Markus Elfring <Markus.Elfring@xxxxxx> wrote:

> > This looks really unusual to have a 'get_device()' hidden in a 'dev_err()' call.
>
> Is there a need to prevent similar function calls by the means of
> advanced source code analysis?

It's a seriously stupid bug so I'd have thought unlikely to
occur often enough to be worth it.

Jonathan

>
> Regards,
> Markus