[PATCH 1/2] lib: 842 - Remove useless checking in add_template()

From: Yunfeng Ye
Date: Sat May 16 2020 - 03:22:17 EST


A warning was found by smatch tool:
"add_template() error: testing array offset 'c' after use."

Fix it by removing the useless checking in add_template().

Signed-off-by: Yunfeng Ye <yeyunfeng@xxxxxxxxxx>
---
lib/842/842_compress.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/lib/842/842_compress.c b/lib/842/842_compress.c
index c02baa4168e1..18255d25781b 100644
--- a/lib/842/842_compress.c
+++ b/lib/842/842_compress.c
@@ -225,9 +225,6 @@ static int add_template(struct sw842_param *p, u8 c)
u8 *t = comp_ops[c];
bool inv = false;

- if (c >= OPS_MAX)
- return -EINVAL;
-
pr_debug("template %x\n", t[4]);

ret = add_bits(p, t[4], OP_BITS);
--
1.8.3.1