Re: [PATCH] gpiolib: notify user-space about line status changes after flags are set

From: Linus Walleij
Date: Sat May 16 2020 - 05:30:51 EST


On Sat, May 9, 2020 at 4:15 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:

> Since the flags can be configured in different ways depending on how the
> line is being requested - we need to call the notifier chain in different
> places separately.

Ooops.

> This comes late in the release cycle but I only recently got down to
> writing libgpiod support for this new ioctl(). When writing test cases
> I noticed this doesn't really work as expected.

This is why I am so grateful about the tests you are doing with
libgpiod! We actually find these problems quickly and not after
years. Thanks!

> This patch fixes the
> issue I identified this week. There may be more coming the following
> week though...

I will pull in your pull request once the next -rc is out as I had already
sent my first pull request, but do not hesitate to bug me about this.

Yours,
Linus Walleij