Re: [PATCH v2 5/7] include: dt-bindings: sound: Add sc7180-lpass bindings header

From: Ajit Pandey
Date: Sat May 16 2020 - 14:14:51 EST


On 5/14/2020 10:18 PM, Mark Brown wrote:
On Thu, May 14, 2020 at 10:08:16PM +0530, Ajit Pandey wrote:

+#define MI2S_PRIMARY 0
+#define MI2S_SECONDARY 1
+
+#define LPASS_MCLK0 0
These look like they could use namespacing. Is primary/secondary
perhaps something that could be a boolean property?

Primary/secondary is a dai id and can be from 0-4 (SC7180 soc driver support only 0-1 at present). Such id is mainly used in dtsi and machine driver to do dai id based configuration for a soc hence we placed them in dt headers file for now.