Re: [PATCH v2 0/3] TTY improve n_gsm support

From: Gregory CLEMENT
Date: Mon May 18 2020 - 06:01:50 EST


Hello,

> Hello,
>
> This series is the second version of patch improving n_gms support
> especially with TELIT LE910. However the fix should benefit to any
> modem supporting cmux.

You can just ignore the emails from this point, I forgot to remove the
remaining .patch!

Sorry for the noise

Gregory

>
> The first patch is just about improving debugging output.
>
> The second one removes a tty optimization which make the LE910 hang.
>
> The last one fixes an issue observed on the LE910 but should benefit
> to all the modem. We observed that pretty quickly the transfer done
> using the virtual tty were blocked. We found that it was due of a
> wakeup to the real tty. Without this fix, the real tty wait for
> indefinitely.
>
> Thanks to Jiri Slaby for the review.
>
> Changelog:
> v1 -> v2:
> - don't replace the pr_info by pr_debug
> - remove the superfluous printk("\n");
> - use --follow option with git log to find the original commit to fix
> - use tty_port_tty_wakeup
> - use 'for' loop instead of 'while'
>
> Gregory
>
> Gregory CLEMENT (3):
> tty: n_gsm: Improve debug output
> tty: n_gsm: Fix SOF skipping
> tty: n_gsm: Fix waking up upper tty layer when room available
>
> drivers/tty/n_gsm.c | 48 +++++++++++++++++++++++----------------------
> 1 file changed, 25 insertions(+), 23 deletions(-)
>
> --
> 2.26.2
>

--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com