Re: [PATCH v2 0/8] exec: Control flow simplifications

From: Linus Torvalds
Date: Mon May 18 2020 - 21:26:20 EST


On Mon, May 18, 2020 at 5:32 PM Eric W. Biederman <ebiederm@xxxxxxxxxxxx> wrote:
>
> It is hard to follow the control flow in exec.c as the code has evolved over
> time and something that used to work one way now works another. This set of
> changes attempts to address the worst of that, to remove unnecessary work
> and to make the code a little easier to follow.

It is indeed hard to follow, and maybe I missed something, but from
what I can tell, your series looks all sane. It certainly seems to
make things much more straightforward.

Of course, exactly _because_ it's such a messy area, maybe it
introduces something odd, but all the patches look relatively
straightforward. And you remove more lines of code than you add, which
is always nice to see.

So ack from me.

Oleg? Jann? Anybody? Do you see anything strange that I missed?

Linus