Re: [PATCH v2] staging: rtl8192u: Merge almost duplicate code

From: Greg Kroah-Hartman
Date: Tue May 19 2020 - 10:16:45 EST


On Sun, May 17, 2020 at 09:40:45PM +0100, Pascal Terjan wrote:
> This causes a change in behaviour:
> - stats also get updated when reordering, this seems like it should be
> the case but those lines were commented out.
> - sub_skb NULL check now happens early in both cases, previously it
> happened only after dereferencing it 12 times, so it may not actually
> be needed.
>
> Signed-off-by: Pascal Terjan <pterjan@xxxxxxxxxx>

This patch adds a new compiler warning, which no patch should do.

Please fix that up and resend.

thanks,

greg k-h