Re: [PATCH v4 0/4] cleaning up the sysctls table (hung_task watchdog)

From: Luis Chamberlain
Date: Wed May 20 2020 - 09:08:09 EST


On Wed, May 20, 2020 at 12:02:26PM +0800, Xiaoming Ni wrote:
> On 2020/5/20 11:31, Andrew Morton wrote:
> > On Tue, 19 May 2020 11:31:07 +0800 Xiaoming Ni <nixiaoming@xxxxxxxxxx> wrote:
> >
> > > Kernel/sysctl.c
> >
> > eek!
> >
> > >
> > > fs/proc/proc_sysctl.c | 2 +-
> > > include/linux/sched/sysctl.h | 14 +--
> > > include/linux/sysctl.h | 13 ++-
> > > kernel/hung_task.c | 77 +++++++++++++++-
> > > kernel/sysctl.c | 214 +++++++------------------------------------
> > > kernel/watchdog.c | 101 ++++++++++++++++++++
> > > 6 files changed, 224 insertions(+), 197 deletions(-)
> >
> > Here's what we presently have happening in linux-next's kernel/sysctl.c:
> >
> > sysctl.c | 3109 ++++++++++++++++++++++++++++++---------------------------------
> > 1 file changed, 1521 insertions(+), 1588 deletions(-)
> >
> >
> > So this is not a good time for your patch!
> >
> > Can I suggest that you set the idea aside and take a look after 5.8-rc1
> > is released?
> >
>
> ok, I will make v5 patch based on 5.8-rc1 after 5.8-rc1 is released,
> And add more sysctl table cleanup.

Xiaoming, I'll coordinate with you on this offline as I have the fs
kernel/sysctl.c stuff out of the way as well.

Luis