Re: [PATCH 3.16 00/99] 3.16.84-rc1 review

[Ben Hutchings]

On Thu, 2020-05-21 at 00:40 -0700, Guenter Roeck wrote:
> On 5/20/20 7:47 PM, Chen-Yu Tsai wrote:
> > On Thu, May 21, 2020 at 5:23 AM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
> > > On 5/20/20 7:13 AM, Ben Hutchings wrote:
> > > > This is the start of the stable review cycle for the 3.16.84 release.
> > > > There are 99 patches in this series, which will be posted as responses
> > > > to this one.  If anyone has any issues with these being applied, please
> > > > let me know.
> > > > 
> > > > Responses should be made by Fri May 22 20:00:00 UTC 2020.
> > > > Anything received after that time might be too late.
> > > > 
> > > Build results:
> > >         total: 135 pass: 135 fail: 0
> > > Qemu test results:
> > >         total: 230 pass: 227 fail: 3
> > > Failed tests:
> > >         arm:cubieboard:multi_v7_defconfig:mem512:sun4i-a10-cubieboard:initrd
> > >         arm:cubieboard:multi_v7_defconfig:usb:mem512:sun4i-a10-cubieboard:rootfs
> > >         arm:cubieboard:multi_v7_defconfig:sata:mem512:sun4i-a10-cubieboard:rootfs
> > > 
> > > The arm tests fail due to a compile error.
> > > 
> > > drivers/clk/tegra/clk-tegra-periph.c:524:65: error: 'CLK_IS_CRITICAL' undeclared here (not in a function); did you mean 'CLK_IS_BASIC'?
> > 
> > This looks like a result of having
> > 
> >       clk: tegra: Mark fuse clock as critical
> >          [bf83b96f87ae2abb1e535306ea53608e8de5dfbb]
> > 
> > In which case you probably need to add
> > 
> >     32b9b1096186 clk: Allow clocks to be marked as CRITICAL
> > 
> 
> Then you might also need commit ef56b79b66f ("clk: fix critical
> clock locking") which fixes it.

At this stage I don't think it makes sense to add the feature to 3.16.

Ben.

-- 
Ben Hutchings
Reality is just a crutch for people who can't handle science fiction.

Attachment: signature.asc
Description: This is a digitally signed message part