Re: [PATCH v2 16/18] nitro_enclaves: Add sample for ioctl interface usage

From: Greg KH
Date: Fri May 22 2020 - 03:11:30 EST


On Fri, May 22, 2020 at 09:29:44AM +0300, Andra Paraschiv wrote:
> Signed-off-by: Alexandru Vasile <lexnv@xxxxxxxxxx>
> Signed-off-by: Andra Paraschiv <andraprs@xxxxxxxxxx>

No changelog?

> ---
> samples/nitro_enclaves/.gitignore | 2 +
> samples/nitro_enclaves/Makefile | 28 +
> .../include/linux/nitro_enclaves.h | 23 +
> .../include/uapi/linux/nitro_enclaves.h | 77 +++

Why are you not using the uapi files from the kernel itself? How are
you going to keep these in sync?

thanks,

greg k-h