Re: [PATCH net v2] net: phy: mscc: fix initialization of the MACsec protocol mode

From: David Miller
Date: Sat May 23 2020 - 19:33:14 EST


From: Antoine Tenart <antoine.tenart@xxxxxxxxxxx>
Date: Fri, 22 May 2020 17:55:45 +0200

> At the very end of the MACsec block initialization in the MSCC PHY
> driver, the MACsec "protocol mode" is set. This setting should be set
> based on the PHY id within the package, as the bank used to access the
> register used depends on this. This was not done correctly, and only the
> first bank was used leading to the two upper PHYs being unstable when
> using the VSC8584. This patch fixes it.
>
> Fixes: 1bbe0ecc2a1a ("net: phy: mscc: macsec initialization")
> Signed-off-by: Antoine Tenart <antoine.tenart@xxxxxxxxxxx>

Applied and queued up for -stable, thanks.