Re: [PATCH 1/2] crypto: virtio: Fix src/dst scatterlist calculation in __virtio_crypto_skcipher_do_req()

From: Markus Elfring
Date: Mon May 25 2020 - 02:05:56 EST

> The system will crash when we insmod crypto/tcrypt.ko whit mode=38.

* I suggest to use the word âwithâ in this sentence.

* Will it be helpful to explain the passed mode number?

> BTW I add a check for sg_nents_for_len() its return value since
> sg_nents_for_len() function could fail.

Please reconsider also development consequences for this suggestion.
Will a separate update step be more appropriate for the addition of
an input parameter validation?

Would you like to add the tag âFixesâ to the commit message?