Re: [PATCH 2/2] crypto: virtio: Fix use-after-free in virtio_crypto_skcipher_finalize_req()

From: Markus Elfring
Date: Mon May 25 2020 - 02:31:00 EST


> â So the system will crash
> at last when this memory be used again.

I would prefer a wording with less typos here.


> We can free the resources before calling ->complete to fix this issue.

* An imperative wording can be nicer.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=9cb1fd0efd195590b828b9b865421ad345a4a145#n151

* You proposed to move a call of the function âcrypto_finalize_skcipher_requestâ.
How does this change fit to the mentioned position?

* Would you like to add the tag âFixesâ to the commit message?

Regards,
Markus