Re: [PATCH] m68k/mac: Don't call via_flush_cache() on Mac IIfx

From: Geert Uytterhoeven
Date: Mon May 25 2020 - 04:41:55 EST

On Wed, May 20, 2020 at 6:41 AM Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
> There is no VIA2 chip on the Mac IIfx, so don't call via_flush_cache().
> This avoids a boot crash which appeared in v5.4.


> Thanks to Stan Johnson for capturing the console log and running git
> bisect.
> Git bisect said commit 8e3a68fb55e0 ("dma-mapping: make
> dma_atomic_pool_init self-contained") is the first "bad" commit. I don't
> know why. Perhaps mach_l2_flush first became reachable with that commit.
> Cc: Joshua Thompson <funaho@xxxxxxxxx>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Reported-and-tested-by: Stan Johnson <userm57@xxxxxxxxx>
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
i.e. will queue in the m68k for-v5.8 branch.



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds