Re: [PATCH v2 2/4] pwm: jz4740: Enhance precision in calculation of duty cycle

From: Uwe Kleine-König
Date: Mon May 25 2020 - 11:38:22 EST

On Mon, May 25, 2020 at 02:57:20PM +0200, Paul Cercueil wrote:
> Calculating the hardware value for the duty from the hardware value of
> the period resulted in a precision loss versus calculating it from the
> clock rate directly.
> (Also remove a cast that doesn't really need to be here)
> Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> ---
> Notes:
> v2: New patch. I don't consider this a fix but an enhancement, since the old
> behaviour was in place since the driver was born in ~2010, so no Fixes tag.

I would not hesitate and add:

Fixes: f6b8a5700057 ("pwm: Add Ingenic JZ4740 support")

Suggested-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Thanks for picking this up,

Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | |