Re: [PATCH] [v2] iio: magnetometer: ak8974: Fix runtime PM imbalance on error

From: Linus Walleij
Date: Tue May 26 2020 - 07:14:12 EST

On Tue, May 26, 2020 at 12:47 PM Dinghao Liu <dinghao.liu@xxxxxxxxxx> wrote:

> When devm_regmap_init_i2c() returns an error code, a pairing
> runtime PM usage counter decrement is needed to keep the
> counter balanced. For error paths after ak8974_set_power(),
> ak8974_detect() and ak8974_reset(), things are the same.
> However, When iio_triggered_buffer_setup() returns an error
> code, there will be two PM usgae counter decrements.
> Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx>
> ---
> Changelog:
> v2: - Change 3 goto targets from "power_off" to
> "disabel_pm". Remove unused lable "power_off".
> Move 3 PM runtime related calls to the end of
> the function.

Thanks for fixing this Dinghao!
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Linus Walleij