Re: [PATCH v1] Bluetooth: hci_qca: Improve controller ID info log level

From: Matthias Kaehlcke
Date: Tue May 26 2020 - 12:06:07 EST

On Tue, May 26, 2020 at 11:35:08AM +0800, Zijun Hu wrote:
> Controller ID info got by VSC EDL_PATCH_GETVER is very
> important, so improve its log level from DEBUG to INFO.
> Signed-off-by: Zijun Hu <zijuhu@xxxxxxxxxxxxxx>
> ---
> drivers/bluetooth/btqca.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
> diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
> index 3ea866d..49e5aeb 100644
> --- a/drivers/bluetooth/btqca.c
> +++ b/drivers/bluetooth/btqca.c
> @@ -74,10 +74,10 @@ int qca_read_soc_version(struct hci_dev *hdev, u32 *soc_version,
> ver = (struct qca_btsoc_version *)(edl->data);
> - BT_DBG("%s: Product:0x%08x", hdev->name, le32_to_cpu(ver->product_id));
> - BT_DBG("%s: Patch :0x%08x", hdev->name, le16_to_cpu(ver->patch_ver));
> - BT_DBG("%s: ROM :0x%08x", hdev->name, le16_to_cpu(ver->rom_ver));
> - BT_DBG("%s: SOC :0x%08x", hdev->name, le32_to_cpu(ver->soc_id));
> + bt_dev_info(hdev, "QCA Product:0x%08x", le32_to_cpu(ver->product_id));
> + bt_dev_info(hdev, "QCA Patch :0x%08x", le16_to_cpu(ver->patch_ver));
> + bt_dev_info(hdev, "QCA ROM :0x%08x", le16_to_cpu(ver->rom_ver));
> + bt_dev_info(hdev, "QCA SOC :0x%08x", le32_to_cpu(ver->soc_id));

nit: Now that these messages become more visible you could consider making the
order a bit more consistent/hierarchical. Not sure what is the product ID vs.
the SoC ID (product is a variant of the SoC?). IMO it would make sense to
start with HW information, going from more generic to more specific, then do
the same for firmware.

Product ID // assuming this is a variant of the SoC
ROM version
Patch version // assuming this is a patch of the ROM firmware (?)

Sorry if I got any of the concepts wrong, from the names they are not entirely
clear to me.

In any case it's just a suggestion, feel free to ignore.

Reviewed-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>