Re: [PATCH v6 3/4] mm/memory.c: Add memory read privilege on page fault handling
From: Thomas Bogendoerfer
Date: Wed May 27 2020 - 04:03:33 EST
On Wed, May 27, 2020 at 09:05:41AM +0800, maobibo wrote:
> On 05/26/2020 05:44 AM, Andrew Morton wrote:
> > On Mon, 25 May 2020 10:52:39 +0800 Bibo Mao <maobibo@xxxxxxxxxxx> wrote:
> >> Here add pte_sw_mkyoung function to make page readable on MIPS
> >> platform during page fault handling. This patch improves page
> >> fault latency about 10% on my MIPS machine with lmbench
> >> lat_pagefault case.
> >> It is noop function on other arches, there is no negative
> >> influence on those architectures.
> > Acked-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > Should I take these, or would the mips tree be preferred? I'm OK
> > either way, but probably the MIPS tree would be better?
> Thanks for reviewing again and again.
> This patch is based on mips-next, maybe MIPS tree will be better.
I'll take your next version then.
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]