Re: [PATCH 4.4 26/65] sched/fair, cpumask: Export for_each_cpu_wrap()
From: Daniel Jordan
Date: Wed May 27 2020 - 10:04:19 EST
On 5/27/20 4:09 AM, Greg KH wrote:
> On Wed, May 27, 2020 at 07:50:56AM +0000, nobuhiro1.iwamatsu@xxxxxxxxxxxxx wrote:
>>> Subject: [PATCH 4.4 26/65] sched/fair, cpumask: Export for_each_cpu_wrap()
>> This commit also needs the following commits:
>> commit d207af2eab3f8668b95ad02b21930481c42806fd
>> Author: Michael Kelley <mhkelley@xxxxxxxxxxx>
>> Date: Wed Feb 14 02:54:03 2018 +0000
>> cpumask: Make for_each_cpu_wrap() available on UP as well
>> for_each_cpu_wrap() was originally added in the #else half of a
>> large "#if NR_CPUS == 1" statement, but was omitted in the #if
>> half. This patch adds the missing #if half to prevent compile
>> errors when NR_CPUS is 1.
>> Reported-by: kbuild test robot <fengguang.wu@xxxxxxxxx>
>> Signed-off-by: Michael Kelley <mhkelley@xxxxxxxxxxx>
>> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
>> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
>> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>> Cc: kys@xxxxxxxxxxxxx
>> Cc: martin.petersen@xxxxxxxxxx
>> Cc: mikelley@xxxxxxxxxxxxx
>> Fixes: c743f0a5c50f ("sched/fair, cpumask: Export for_each_cpu_wrap()")
>> Link: http://lkml.kernel.org/r/SN6PR1901MB2045F087F59450507D4FCC17CBF50@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
>> Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
>> Please apply this commit.
> Good catch, now queued up, thanks.
I left this commit out because the 4.4 kernel only uses
cpumask_next_wrap in padata, which is only enabled for SMP kernels, but
it's probably best to be safe.