Re: [PATCH v25 01/16] dt: bindings: Add multicolor class dt bindings documention
From: Rob Herring
Date: Wed May 27 2020 - 10:35:22 EST
On Wed, May 27, 2020 at 7:39 AM Pavel Machek <pavel@xxxxxx> wrote:
> Thanks for reviews!
> > > +additionalProperties: false
> > > +...
> > > diff --git a/drivers/leds/led-core.c b/drivers/leds/led-core.c
> > This isn't a binding file. Belongs in another patch.
> These constants are directly related to the binding. It makes sense to
> go in one patch...
Yes, the header does go in this patch, but kernel subsystem files do not.
Part of the reason for separating is we generate a DT only repository
which filters out all the kernel code. Ideally this is just filtering
out commits and the commit messages still make sense.