Re: [PATCH] x86: crypto: fix building crc32c with clang ias
From: Nathan Chancellor
Date: Wed May 27 2020 - 15:35:04 EST
On Wed, May 27, 2020 at 08:24:35PM +0200, Arnd Bergmann wrote:
> On Wed, May 27, 2020 at 6:42 PM Nathan Chancellor
> <natechancellor@xxxxxxxxx> wrote:
> > On Wed, May 27, 2020 at 04:17:40PM +0200, Arnd Bergmann wrote:
> > > The clang integrated assembler complains about movzxw:
> > >
> > > arch/x86/crypto/crc32c-pcl-intel-asm_64.S:173:2: error: invalid instruction mnemonic 'movzxw'
> > >
> > > It seems that movzwq is the mnemonic that it expects instead,
> > > and this is what objdump prints when disassembling the file.
> > >
> > > Fixes: 6a8ce1ef3940 ("crypto: crc32c - Optimize CRC32C calculation with PCLMULQDQ instruction")
> > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> > We had an identical patch pending from another contributor, see the
> > discussion and result in the issue below.
> > https://github.com/ClangBuiltLinux/linux/issues/1010
> > Reviewed-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> Was the other one submitted upstream? If yes, let's use that one.
No, at least not that I saw. I've added Diab to CC now though to