Re: [PATCH resend 3/3] mm: fix LRU balancing effect of new transparent huge pages

From: Shakeel Butt
Date: Wed May 27 2020 - 17:36:02 EST


On Wed, May 27, 2020 at 1:46 PM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, 27 May 2020 15:41:48 -0400 Johannes Weiner <hannes@xxxxxxxxxxx> wrote:
>
> > On Wed, May 27, 2020 at 11:29:58AM -0700, Shakeel Butt wrote:
> > > From: Johannes Weiner <hannes@xxxxxxxxxxx>
> > >
> > > Currently, THP are counted as single pages until they are split right
> > > before being swapped out. However, at that point the VM is already in
> > > the middle of reclaim, and adjusting the LRU balance then is useless.
> > >
> > > Always account THP by the number of basepages, and remove the fixup
> > > from the splitting path.
> > >
> > > Signed-off-by: Johannes Weiner <hannes@xxxxxxxxxxx>
> > > Signed-off-by: Shakeel Butt <shakeelb@xxxxxxxxxx>
> >
> > This is now already in mm as part of the "mm: balance LRU lists based
> > on relative thrashing" series that I sent out last week and where it
> > was originally from.
>
> Yup. I hope [1/3] and [2/3] weren't urgent?

No urgency.