[PATCH v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq()

From: qiang.zhang
Date: Wed May 27 2020 - 21:21:20 EST

From: Zhang Qiang <qiang.zhang@xxxxxxxxxxxxx>

The data structure member "wq->rescuer" was reset to a null pointer
in one if branch. It was passed to a call of the function "kfree"
in the callback function "rcu_free_wq" (which was eventually executed).
The function "kfree" does not perform more meaningful data processing
for a passed null pointer (besides immediately returning from such a call).
Thus delete this function call which became unnecessary with the referenced
software update.

Fixes: def98c84b6cd ("workqueue: Fix spurious sanity check failures in destroy_workqueue()")

Co-developed-by: Markus Elfring <Markus.Elfring@xxxxxx>
Signed-off-by: Zhang Qiang <qiang.zhang@xxxxxxxxxxxxx>
Modify weakly submitted information.

kernel/workqueue.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/workqueue.c b/kernel/workqueue.c
index 891ccad5f271..a2451cdcd503 100644
--- a/kernel/workqueue.c
+++ b/kernel/workqueue.c
@@ -3491,7 +3491,6 @@ static void rcu_free_wq(struct rcu_head *rcu)

- kfree(wq->rescuer);