Re: [PATCH 02/10] iommu/amd: Unexport get_dev_data()

From: Christoph Hellwig
Date: Thu May 28 2020 - 02:15:09 EST

On Wed, May 27, 2020 at 01:53:05PM +0200, Joerg Roedel wrote:
> From: Joerg Roedel <jroedel@xxxxxxx>
> This function is internal to the AMD IOMMU driver and only exported
> because the amd_iommu_v2 modules calls it. But the reason it is called
> from there could better be handled by amd_iommu_is_attach_deferred().
> So unexport get_dev_data() and use amd_iommu_is_attach_deferred()
> instead.

Btw, what is the reason amd_iommu_v2 is a separate module? It is
very little code, and other drivers seem to just integrate such