Re: [PATCH 06/14] fs: remove the call_{read,write}_iter functions

From: Christoph Hellwig
Date: Fri May 29 2020 - 01:51:38 EST


On Thu, May 28, 2020 at 07:56:43PM +0100, Al Viro wrote:
> On Thu, May 28, 2020 at 07:40:35AM +0200, Christoph Hellwig wrote:
> > Just open coding the methods calls is a lot easier to follow.
>
> Not sure about this one, TBH - it's harder to grep that way, since
> you get all the initializers for read_iter/write_iter thrown into
> the mix. Sure, you can do something like '\->[ ]*read_iter\>',
> but it's a PITA.

Which you have to do anyway as not all calls go through these weird
helpers.