Re: [PATCH V7 1/3] dt-bindings: geni-se: Convert QUP geni-se bindings to YAML
From: Rob Herring
Date: Fri May 29 2020 - 13:57:43 EST
On Wed, May 27, 2020 at 11:57:42AM +0530, Akash Asthana wrote:
> Convert QUP geni-se bindings to DT schema format using json-schema.
> Signed-off-by: Akash Asthana <akashast@xxxxxxxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>
> Changes in V2:
> - As per Stephen's comment corrected defintion of interrupts for UART node.
> Any valid UART node must contain atleast 1 interrupts.
> Changes in V3:
> - As per Rob's comment, added number of reg entries for reg property.
> - As per Rob's comment, corrected unit address to hex.
> - As per Rob's comment, created a pattern which matches everything common
> to geni based I2C, SPI and UART controller and then one pattern for each.
> - As per Rob's comment, restored original example.
> Changes in V4:
> - Resolve below compilation error reported from bot.
> qcom,geni-se.yaml: properties:clocks:minItems: False schema does not allow 2
> qcom,geni-se.yaml: properties:clocks:maxItems: False schema does not allow 2
> Documentation/devicetree/bindings/Makefile:12: recipe for target
> 'Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.example.dts' failed
> make: *** [Documentation/devicetree/bindings/soc/qcom/
> qcom,geni-se.example.dts] Error 1
> Makefile:1263: recipe for target 'dt_binding_check' failed
> make: *** [dt_binding_check] Error 2
> Changes in V6:
> - Added reg entry for soc@0 example node to address below warning.
> : Warning (unit_address_vs_reg): /example-0/soc@0: node has a unit name,
> but no reg or ranges property
> Changes in V7:
> - No change.
> .../devicetree/bindings/soc/qcom/qcom,geni-se.txt | 94 ---------
> .../devicetree/bindings/soc/qcom/qcom,geni-se.yaml | 210 +++++++++++++++++++++
> 2 files changed, 210 insertions(+), 94 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.txt
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml