Re: [PATCH 1/9] staging: media: atomisp: fix incorrect NULL pointer check

From: Mauro Carvalho Chehab
Date: Sat May 30 2020 - 05:22:24 EST


Em Fri, 29 May 2020 22:31:44 +0200
Arnd Bergmann <arnd@xxxxxxxx> escreveu:

> On Fri, May 29, 2020 at 10:23 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
> >
> > On Fri, May 29, 2020 at 10:04 PM 'Nick Desaulniers' via Clang Built
> > Linux <clang-built-linux@xxxxxxxxxxxxxxxx> wrote:
> > >
> > > See also Nathan's 7 patch series.
> > > https://lore.kernel.org/lkml/20200527071150.3381228-1-natechancellor@xxxxxxxxx/
> > >
> > > Might be some overlap between series?
> > >
> >
> > Probably. I really should have checked when I saw the number of warnings.
> >
> > At least this gives Mauro a chance to double-check the changes and see if
> > Nathan and I came to different conclusions on any of them.
>
> I checked now and found that the overlap is smaller than I expected.
> In each case, Nathans' solution seems more complete than mine,
> so this patch ("staging: media: atomisp: fix incorrect NULL pointer check")
> and also "staging: media: atomisp: fix a type conversion warning" can be
> dropped, but I think the others are still needed.

Hi Arnd,

I applied most of the patches from you. I had to add two extra patches
before this one:

[PATCH 5/9] staging: media: atomisp: fix stack overflow in init_pipe_defaults()

And rebase it, because otherwise gcc would fail to compile here.

I'm placing the patches I have so far ready for atomisp on this
tree:

https://git.linuxtv.org/mchehab/media-next.git/log/

Thanks,
Mauro