Re: [PATCH v2 4/4] dt-bindings: iio: scd30: add device binding file

From: Jonathan Cameron
Date: Sun May 31 2020 - 06:19:30 EST


On Sat, 30 May 2020 23:36:30 +0200
Tomasz Duszynski <tomasz.duszynski@xxxxxxxxxxx> wrote:

> Add SCD30 sensor binding file.
>
> Signed-off-by: Tomasz Duszynski <tomasz.duszynski@xxxxxxxxxxx>
> ---
> .../iio/chemical/sensirion,scd30.yaml | 68 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 69 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml
>
> diff --git a/Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml b/Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml
> new file mode 100644
> index 000000000000..34cc3925d64d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/chemical/sensirion,scd30.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sensirion SCD30 carbon dioxide sensor
> +
> +maintainers:
> + - Tomasz Duszynski <tomasz.duszynski@xxxxxxxxxxx>
> +
> +description: |
> + Air quality sensor capable of measuring co2 concentration, temperature
> + and relative humidity.
> +
> +properties:
> + compatible:
> + enum:
> + - sensirion,scd30
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + vdd-supply: true
> +
> + sensirion,sel-gpios:
> + description: GPIO connected to the SEL line
> + maxItems: 1
> +
> + sensirion,pwm-gpios:
> + description: GPIO connected to the PWM line
> + maxItems: 1
> +
> +required:
> + - compatible
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + # include <dt-bindings/interrupt-controller/irq.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + scd30@61 {

Nodes should have generic names. Not sure we have an appropriate
one in the spec, but as main focus of people using this will be
c02 herpas

c02@61?

Rob may well have a better suggestion!

> + compatible = "sensirion,scd30";
> + reg = <0x61>;
> + vdd-supply = <&vdd>;
> + interrupt-parent = <&gpio0>;
> + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
> + };
> + };
> + - |
> + # include <dt-bindings/interrupt-controller/irq.h>
> + serial {
> + scd30 {
> + compatible = "sensirion,scd30";
> + vdd-supply = <&vdd>;
> + interrupt-parent = <&gpio0>;
> + interrupts = <0 IRQ_TYPE_LEVEL_HIGH>;
> + };
> + };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 5db4b446c8ba..0ab9cf39e051 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -15140,6 +15140,7 @@ F: include/uapi/linux/phantom.h
> SENSIRION SCD30 CARBON DIOXIDE SENSOR DRIVER
> M: Tomasz Duszynski <tomasz.duszynski@xxxxxxxxxxx>
> S: Maintained
> +F: Documentation/devicetree/bindings/iio/chemical/sensirion,scd30.yaml
> F: drivers/iio/chemical/scd30.h
> F: drivers/iio/chemical/scd30_core.c
> F: drivers/iio/chemical/scd30_i2c.c