Re: [PATCH v2] power: supply: bq24190_charger: Fix runtime PM imbalance in bq24190_sysfs_store()

From: Markus Elfring
Date: Sun May 31 2020 - 11:02:07 EST


> pm_runtime_get_sync() increments the runtime PM usage counter even
> it returns an error code. Thus a pairing decrement is needed on
> the error handling path to keep the counter balanced.

How do you think about a wording variant like the following?

Change description:
The PM runtime usage counter is incremented even if a call of
the function âpm_runtime_get_syncâ failed. Thus decrement it also
in an error case so that the reference counting is kept consistent.


Would you like to add the tag âFixesâ to the commit message?

Regards,
Markus