Re: [PATCH v3 01/18] nitro_enclaves: Add ioctl interface definition

From: Benjamin Herrenschmidt
Date: Sun May 31 2020 - 23:03:27 EST


On Wed, 2020-05-27 at 09:49 +0100, Stefan Hajnoczi wrote:
>
> What about feature bits or a API version number field? If you add
> features to the NE driver, how will userspace detect them?
>
> Even if you intend to always compile userspace against the exact kernel
> headers that the program will run on, it can still be useful to have an
> API version for informational purposes and to easily prevent user
> errors (running a new userspace binary on an old kernel where the API is
> different).
>
> Finally, reserved struct fields may come in handy in the future. That
> way userspace and the kernel don't need to explicitly handle multiple
> struct sizes.

Beware, Greg might disagree :)

That said, yes, at least a way to query the API version would be
useful.

Cheers,
Ben.