Re: [PATCH 1/2] ubifs: Fix potential memory leaks while iterating entries

From: Richard Weinberger
Date: Mon Jun 01 2020 - 09:55:25 EST


On Mon, Jun 1, 2020 at 3:46 PM Zhihao Cheng <chengzhihao1@xxxxxxxxxx> wrote:
>
> å 2020/6/1 20:00, Markus Elfring åé:
> >> Fix some potential memory leaks in error handling branches while
> >> iterating xattr entries.
> > Such information is useful.
> >
> >
> >> For example, function ubifs_tnc_remove_ino()
> >> forgets to free pxent if it exists. Similar problems also exist in
> >> ubifs_purge_xattrs(), ubifs_add_orphan() and ubifs_jnl_write_inode().
> > Can an other wording variant be a bit nicer?
> Thanks for reminding, I will improve this description.

The description is fine. No need to resend. Patch will be queued after
the merge window.
Thanks for fixing these issues!

--
Thanks,
//richard